Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used HiltViewModel to provide ViewModels #128

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Used HiltViewModel to provide ViewModels #128

merged 1 commit into from
Oct 4, 2022

Conversation

Devendra34
Copy link
Contributor

Fixes #124

  • Deleted all the ViewModelFactory classes. Instead, HiltViewModel being used to provide ViewModels in activity/fragments.
  • Deleted all the UseCase fields which were passed to ViewModelFactory from activity/fragments.
  • In cases where the ViewModel needs data from SafeArgs, it has been provided via SavedStateHandle.

@hieuwu hieuwu self-requested a review October 3, 2022 16:17
hieuwu
hieuwu approved these changes Oct 4, 2022
View reviewed changes
Copy link
Owner

@hieuwu hieuwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!. Very impressive

@hieuwu hieuwu merged commit 11319b4 into hieuwu:main Oct 4, 2022
@Devendra34 Devendra34 mentioned this pull request Oct 4, 2022
Merged
@hieuwu
Copy link
Owner

hieuwu commented Oct 5, 2022

@all-contributors please add @Devendra34 for code

@allcontributors allcontributors bot mentioned this pull request Oct 5, 2022
Merged
@allcontributors
Copy link
Contributor

@hieuwu

I've put up a pull request to add @Devendra34! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieuwu hieuwu hieuwu approved these changes

Assignees

@Devendra34 Devendra34

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use HiltViewModel to provide ViewModels
2 participants
@Devendra34 @hieuwu