Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the bugs and improved cart UI. #126

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Conversation

AmartyaSingh97
Copy link
Contributor

First of all, fixed the delete items from the cart button which was not working. Added a simple delete icon in a cart rather than an option thing to make it more user-friendly and good-looking.
Changed the edit-text type to text view in the cart while showing a number of items.

XRecorder_03102022_005107.mp4

Copy link
Owner

@hieuwu hieuwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch once again.! When I started the project, I decided to use context menu to remove the item from cart. After using the swipe to delete I forgot to remove the code. ^_^

@hieuwu
Copy link
Owner

hieuwu commented Oct 3, 2022

Actually we have swipe to remove item. How do you think about doing something else with current delete button just added? @AmartyaSingh97

@AmartyaSingh97
Copy link
Contributor Author

Actually we have swipe to remove item. How do you think about doing something else with current delete button just added? @AmartyaSingh97

Screenshot_20221003-172526_Amazon.jpg

I went through many e-commerce websites (for ref: Amazon in the ss above)...they have both swipe as well as button thing to remove items. New users or users with very less technical knowledge who have just started using the app will get confused...that's why i added the delete button in addition to the swipe thing.

@AmartyaSingh97
Copy link
Contributor Author

Actually we have swipe to remove item. How do you think about doing something else with current delete button just added? @AmartyaSingh97

But still if you don't want the delete button we can change it to add to favorites button which will add the item to favorites list.

@hieuwu
Copy link
Owner

hieuwu commented Oct 3, 2022

Actually we have swipe to remove item. How do you think about doing something else with current delete button just added? @AmartyaSingh97

Screenshot_20221003-172526_Amazon.jpg

I went through many e-commerce websites (for ref: Amazon in the ss above)...they have both swipe as well as button thing to remove items. New users or users with very less technical knowledge who have just started using the app will get confused...that's why i added the delete button in addition to the swipe thing.

Nice. Thank you very much for providing such detailed example. It's good to learn this case

@hieuwu hieuwu merged commit a7f931b into hieuwu:main Oct 3, 2022
@hieuwu
Copy link
Owner

hieuwu commented Oct 5, 2022

@all-contributors please add @AmartyaSingh97 for design,code

@allcontributors
Copy link
Contributor

@hieuwu

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@hieuwu
Copy link
Owner

hieuwu commented Oct 5, 2022

@all-contributors please add @AmartyaSingh97 for his contributions

@allcontributors
Copy link
Contributor

@hieuwu

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@hieuwu
Copy link
Owner

hieuwu commented Oct 5, 2022

@all-contributors please add @AmartyaSingh97 for design

@allcontributors
Copy link
Contributor

@hieuwu

I've put up a pull request to add @AmartyaSingh97! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants