-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the bugs and improved cart UI. #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch once again.! When I started the project, I decided to use context menu to remove the item from cart. After using the swipe to delete I forgot to remove the code. ^_^
Actually we have swipe to remove item. How do you think about doing something else with current delete button just added? @AmartyaSingh97 |
I went through many e-commerce websites (for ref: Amazon in the ss above)...they have both swipe as well as button thing to remove items. New users or users with very less technical knowledge who have just started using the app will get confused...that's why i added the delete button in addition to the swipe thing. |
But still if you don't want the delete button we can change it to add to favorites button which will add the item to favorites list. |
Nice. Thank you very much for providing such detailed example. It's good to learn this case |
@all-contributors please add @AmartyaSingh97 for design,code |
I couldn't determine any contributions to add, did you specify any contributions? |
@all-contributors please add @AmartyaSingh97 for his contributions |
I couldn't determine any contributions to add, did you specify any contributions? |
@all-contributors please add @AmartyaSingh97 for design |
I've put up a pull request to add @AmartyaSingh97! 🎉 |
First of all, fixed the delete items from the cart button which was not working. Added a simple delete icon in a cart rather than an option thing to make it more user-friendly and good-looking.
Changed the edit-text type to text view in the cart while showing a number of items.
XRecorder_03102022_005107.mp4