Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Can not add the same item to cart #131

Closed
hieuwu opened this issue Oct 5, 2022 · 2 comments
Closed

Bug - Can not add the same item to cart #131

hieuwu opened this issue Oct 5, 2022 · 2 comments
Labels
bug Something isn't working hacktoberfest

Comments

@hieuwu
Copy link
Owner

hieuwu commented Oct 5, 2022

Thank you Devendra34 for pointing this out
Describe the bug
Can not add the same item to cart. We should be able to add the same item to cart

To Reproduce
Steps to reproduce the behavior:

  1. Launch the app and add some item from shop fragment using plus icon
  2. open cart bottom sheet. (added items are shown properly till here)
  3. now close this bottom sheet and add another item same as step 1
  4. open the cart bottom sheet again. Now you will not see the recently added item in the list

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
https://user-images.githubusercontent.com/51832211/193946013-965e3d7e-5c2a-48b6-88b2-f917232f622c.mp4

Additional context
Looks like this is due to the latest PR merged (#130 )

@hieuwu hieuwu added bug Something isn't working hacktoberfest labels Oct 5, 2022
@hieuwu
Copy link
Owner Author

hieuwu commented Oct 5, 2022

Hi @DeKaN , could you please take a look at this? It's ok if you don't have time, please let me know.

@DeKaN
Copy link
Contributor

DeKaN commented Oct 5, 2022

@hieuwu I replaced hot observable by cold observable at this line and it seems the cause of this bug

DeKaN added a commit to DeKaN/android-groceries-store that referenced this issue Oct 5, 2022
DeKaN added a commit to DeKaN/android-groceries-store that referenced this issue Oct 5, 2022
@DeKaN DeKaN mentioned this issue Oct 5, 2022
hieuwu added a commit that referenced this issue Oct 5, 2022
@hieuwu hieuwu closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants