Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use JCERandom as the default RNG #606

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jun 23, 2020

The current implementation relies on VMPCRandomGenerator for random number generation if BouncyCastle is registered, otherwise it falls back to SecureRandom. Nowadays, SecureRandom should always be the best available option, whereas VMPCRandomGenerator has known weaknesses.

The current implementation relies on `VMPCRandomGenerator` for random number generation if BouncyCastle is registered, otherwise it falls back to `SecureRandom`. Nowadays, `SecureRandom` should always be the best available option, whereas `VMPCRandomGenerator` [has known weaknesses](https://books.google.de/books?id=niO6BQAAQBAJ&pg=PA140&lpg=PA140&dq=vmpc+prng&source=bl&ots=QAdZJOT607&sig=ACfU3U0Edqlpm08iRZJLxeWGQNwNQz7WsQ&hl=en&sa=X&ved=2ahUKEwjd2Zyr9pfqAhXWMMAKHT70AioQ6AEwDnoECAoQAQ#v=onepage&q=vmpc%20prng&f=false).
@fmeum fmeum requested a review from hierynomus as a code owner June 23, 2020 12:32
@hierynomus hierynomus merged commit 3c85b86 into hierynomus:master Jun 23, 2020
@hierynomus
Copy link
Owner

Thanks!

@fmeum fmeum deleted the patch-2 branch June 23, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants