Bugfix/signature conversion #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment
Sep 15, 2017
Repository owner
deleted a comment
Sep 15, 2017
Repository owner
deleted a comment
Sep 15, 2017
Repository owner
deleted a comment
Sep 15, 2017
Repository owner
deleted a comment
Sep 15, 2017
Repository owner
deleted a comment
Sep 15, 2017
Starting in Java 8u121, DSA signatures that contain "redundant leading 0s" are considered invalid. This commit fixes the conversion between the encoding we get from SSH servers (mpint) and the encoding the JCA expects (ASN.1). Thanks to Jurrie Overgoor for fixing. This is a port of his work: https://github.com/Jurrie/jsch-111-bugfix
Repository owner
deleted a comment
Sep 17, 2017
|
It looks like I need permission from my company to create this PR, so I'm declining it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #354 and #355.
Thanks to @Jurrie for identifying these issues. This is a port of his work to fix JSch #111.