Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: naming convention #2303

Merged

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented May 31, 2024

Description:

Fixing the wrong naming convention of TokenUpdateNftsTransaction.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v svetoslav-nikol0v requested review from a team as code owners May 31, 2024 10:24
@svetoslav-nikol0v svetoslav-nikol0v requested review from rwalworth and removed request for rwalworth May 31, 2024 10:24
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
74.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svetoslav-nikol0v svetoslav-nikol0v merged commit 14489c9 into main Jun 6, 2024
8 of 9 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the fix-naming-convention-token-update-nfts-transaction branch June 6, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants