fix: deserialize the FileAppendTransaction #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
svetoslav-nikol0v
requested review from
SimiHunjan,
ochikov and
petreze
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2145 +/- ##
===========================================
- Coverage 84.22% 84.21% -0.01%
===========================================
Files 305 305
Lines 76202 76208 +6
===========================================
+ Hits 64178 64182 +4
- Misses 12024 12026 +2 ☔ View full report in Codecov by Sentry. |
ochikov
approved these changes
Feb 20, 2024
svetoslav-nikol0v
deleted the
2144-deserializing-fileappendtransaction-hangs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Check if the node IDs list is empty or not.
Fixes #2144
Checklist