Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding signerNonce field #2133

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented Feb 12, 2024

Description:

Added signer_nonce field defined in v0.47.0 proto which is needed for HIP-844. Updated SDK to use the new proto release.

Related issue(s):

Fixes #2108

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svetoslav-nikol0v svetoslav-nikol0v force-pushed the 2108-add-hip-844-handling-and-externalisation-improvements-for-account-nonce-updates branch from f83d1b9 to 23325a7 Compare February 23, 2024 13:39
@svetoslav-nikol0v svetoslav-nikol0v marked this pull request as ready for review February 27, 2024 10:11
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (0feddb2) to head (e246de0).

❗ Current head e246de0 differs from pull request most recent head 51b684b. Consider uploading reports for the commit 51b684b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2133      +/-   ##
===========================================
- Coverage    84.33%   84.26%   -0.08%     
===========================================
  Files          305       53     -252     
  Lines        76228    11432   -64796     
===========================================
- Hits         64289     9633   -54656     
+ Misses       11939     1799   -10140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

petreze and others added 5 commits February 28, 2024 11:51
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v svetoslav-nikol0v force-pushed the 2108-add-hip-844-handling-and-externalisation-improvements-for-account-nonce-updates branch from 51b684b to e35452a Compare February 28, 2024 14:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (0feddb2) to head (e246de0).

❗ Current head e246de0 differs from pull request most recent head e35452a. Consider uploading reports for the commit e35452a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2133      +/-   ##
===========================================
- Coverage    84.33%   84.26%   -0.08%     
===========================================
  Files          305       53     -252     
  Lines        76228    11432   -64796     
===========================================
- Hits         64289     9633   -54656     
+ Misses       11939     1799   -10140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIP 844: Handling and externalisation improvements for account nonce updates
3 participants