Decrement unhealthy nodes count on readmit time expiry #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
|
Kudos, SonarCloud Quality Gate passed!
|
petreze
changed the title
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
This was
linked to
issues
May 26, 2023
monokaijs
pushed a commit
to monostarter/u2u-sdk-js
that referenced
this pull request
Jul 5, 2023
…1613) * decrement unhealthy nodes on readmit time expiry Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue where the
unhealthyNodesCountis not updated upon returning the node fromunhealthytohealthy.This happens whenever the readmitTime period expires, then we consider the node to be potentially available again
Related issue(s):
Fixes #1524 #1606
Notes for reviewer:
Decrement
unhealthyNodesCountwhen we return the node to the healthy list of nodesChecklist