Removed unnecessary check #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: ochikov <ognyan@limechain.tech>
Signed-off-by: ochikov <ognyan@limechain.tech>
Signed-off-by: ochikov <ognyan@limechain.tech>
Signed-off-by: ochikov <ognyan@limechain.tech>
|
Kudos, SonarCloud Quality Gate passed!
|
ochikov
approved these changes
Feb 1, 2023
ochikov
added a commit
that referenced
this pull request
Feb 2, 2023
* added some supportability for hip-583 Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * added deprecation of methods and some refactoring Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * remove unused aliasEvmAddress field Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * added creation of AccountId examples Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * AccountId examples refactoring Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * init hip583 examples Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * add examples and fix tx model Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * after lint Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * almost finalized the examples, getting data from mirror node works Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * new proto package version version Signed-off-by: ochikov <ognyan@limechain.tech> * use newer version for protobufs Signed-off-by: ochikov <ognyan@limechain.tech> * proto updates and examples enhancements Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * fixed build errors Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update the proto package install task Signed-off-by: ochikov <ognyan@limechain.tech> * adjusted hip-583 examples Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * example updates and fixes Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update examples and remove unnecessary step Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * add fromEvmPublicAddress() to AccountId Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * transfer using evm address enhancements Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * fixed all of the examples plus added 2 new status codes from services Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * New proto version Signed-off-by: ochikov <ognyan@limechain.tech> * make the sdk to use new proto version Signed-off-by: ochikov <ognyan@limechain.tech> * fixed proto files Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * remove status codes, need separate branch Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * add new status codes Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * fixed lint errors after task build Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update pnpm lock files Signed-off-by: ochikov <ognyan@limechain.tech> * Update the package.json version Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/timeout issue (#1414) * add new status codes (#1400) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Fix the workflow for address book update and the workflow for timeout error processing Signed-off-by: ochikov <ognyan@limechain.tech> * Integration tests fixes with new account and logging of the failed address book query Signed-off-by: ochikov <ognyan@limechain.tech> * remove unused imports Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: petreze <petar.tonev@limechain.tech> * Update package.json Signed-off-by: ochikov <ognyan@limechain.tech> * Update package.json Signed-off-by: ochikov <ognyan@limechain.tech> * fix ping to throw (#1426) Signed-off-by: ochikov <ognyan@limechain.tech> * Bump up dependencies (#1402) * add new status codes (#1400) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Bump up dependencies Signed-off-by: ochikov <ognyan@limechain.tech> * Cast the values so TS won't throw an error Signed-off-by: ochikov <ognyan@limechain.tech> * update package.json with new versions Signed-off-by: ochikov <ognyan@limechain.tech> * revert the grpc version update due to breaking changes Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: petreze <petar.tonev@limechain.tech> * removed unnecessary check Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * revert refactor Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Removed unnecessary check (#1429) * removed unnecessary check Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Update package.json of cryptography Signed-off-by: ochikov <ognyan@limechain.tech> * update the cryptography package used in the sdk Signed-off-by: ochikov <ognyan@limechain.tech> * fix integration test for topic message query Signed-off-by: ochikov <ognyan@limechain.tech> * remove the only from the failing test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> * Fix inaccurate cost calculation (#1430) * fix inaccurate cost calculation Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * rename misleading comment Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update the package version Signed-off-by: ochikov <ognyan@limechain.tech> * fix get cost and unit test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: Petar Tonev <petar.tonev@limechain.tech>
petreze
added a commit
that referenced
this pull request
Mar 7, 2023
* add new status codes (#1400) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Release/v2.20.0 beta.4 (#1431) * added some supportability for hip-583 Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * added deprecation of methods and some refactoring Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * remove unused aliasEvmAddress field Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * added creation of AccountId examples Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * AccountId examples refactoring Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * init hip583 examples Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * add examples and fix tx model Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * after lint Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * almost finalized the examples, getting data from mirror node works Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * new proto package version version Signed-off-by: ochikov <ognyan@limechain.tech> * use newer version for protobufs Signed-off-by: ochikov <ognyan@limechain.tech> * proto updates and examples enhancements Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * fixed build errors Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update the proto package install task Signed-off-by: ochikov <ognyan@limechain.tech> * adjusted hip-583 examples Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * example updates and fixes Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update examples and remove unnecessary step Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * add fromEvmPublicAddress() to AccountId Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * transfer using evm address enhancements Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * fixed all of the examples plus added 2 new status codes from services Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * New proto version Signed-off-by: ochikov <ognyan@limechain.tech> * make the sdk to use new proto version Signed-off-by: ochikov <ognyan@limechain.tech> * fixed proto files Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * remove status codes, need separate branch Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * add new status codes Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * fixed lint errors after task build Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update pnpm lock files Signed-off-by: ochikov <ognyan@limechain.tech> * Update the package.json version Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/timeout issue (#1414) * add new status codes (#1400) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Fix the workflow for address book update and the workflow for timeout error processing Signed-off-by: ochikov <ognyan@limechain.tech> * Integration tests fixes with new account and logging of the failed address book query Signed-off-by: ochikov <ognyan@limechain.tech> * remove unused imports Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: petreze <petar.tonev@limechain.tech> * Update package.json Signed-off-by: ochikov <ognyan@limechain.tech> * Update package.json Signed-off-by: ochikov <ognyan@limechain.tech> * fix ping to throw (#1426) Signed-off-by: ochikov <ognyan@limechain.tech> * Bump up dependencies (#1402) * add new status codes (#1400) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Bump up dependencies Signed-off-by: ochikov <ognyan@limechain.tech> * Cast the values so TS won't throw an error Signed-off-by: ochikov <ognyan@limechain.tech> * update package.json with new versions Signed-off-by: ochikov <ognyan@limechain.tech> * revert the grpc version update due to breaking changes Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: petreze <petar.tonev@limechain.tech> * removed unnecessary check Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * revert refactor Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Removed unnecessary check (#1429) * removed unnecessary check Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Update package.json of cryptography Signed-off-by: ochikov <ognyan@limechain.tech> * update the cryptography package used in the sdk Signed-off-by: ochikov <ognyan@limechain.tech> * fix integration test for topic message query Signed-off-by: ochikov <ognyan@limechain.tech> * remove the only from the failing test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> * Fix inaccurate cost calculation (#1430) * fix inaccurate cost calculation Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * rename misleading comment Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update the package version Signed-off-by: ochikov <ognyan@limechain.tech> * fix get cost and unit test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: Petar Tonev <petar.tonev@limechain.tech> * chore(deps-dev): bump typescript in /examples/react-native-example (#1438) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.9.4 to 4.9.5. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.9.4...v4.9.5) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump react-native in /examples/react-native-example (#1437) Bumps [react-native](https://github.com/facebook/react-native) from 0.71.1 to 0.71.2. - [Release notes](https://github.com/facebook/react-native/releases) - [Changelog](https://github.com/facebook/react-native/blob/main/CHANGELOG.md) - [Commits](facebook/react-native@v0.71.1...v0.71.2) --- updated-dependencies: - dependency-name: react-native dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump react-native-web in /examples/react-native-example (#1436) Bumps [react-native-web](https://github.com/necolas/react-native-web) from 0.18.10 to 0.18.12. - [Release notes](https://github.com/necolas/react-native-web/releases) - [Commits](necolas/react-native-web@0.18.10...0.18.12) --- updated-dependencies: - dependency-name: react-native-web dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump ua-parser-js in /examples/react-native-example (#1435) Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.31...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump decode-uri-component in /examples/react-native-example (#1434) Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update axios Signed-off-by: ochikov <ognyan@limechain.tech> * update the playwright package Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/update mirror endpoints (#1448) * Fix _maxAutomaticTokenAssociations in contract create and contract up… (#1444) * Fix _maxAutomaticTokenAssociations in contract create and contract update transactions Signed-off-by: ochikov <ognyan@limechain.tech> * set the fields default to null Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * Update the mirror node endpoints Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * Release/v2.20.0 (#1464) * Fix _maxAutomaticTokenAssociations in contract create and contract up… (#1444) * Fix _maxAutomaticTokenAssociations in contract create and contract update transactions Signed-off-by: ochikov <ognyan@limechain.tech> * set the fields default to null Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * Feature/extend ethereumflow (#1447) * init progress Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Extend ethereum flow to accept maxChunks Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: Petar Tonev <petar.tonev@limechain.tech> * Add delete nft allowances and add delegate spender functionality (#1452) * small refactoring Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Fix/update mirror endpoints (#1448) * Fix _maxAutomaticTokenAssociations in contract create and contract up… (#1444) * Fix _maxAutomaticTokenAssociations in contract create and contract update transactions Signed-off-by: ochikov <ognyan@limechain.tech> * set the fields default to null Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * Update the mirror node endpoints Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * add missing functionalities from hip-336 nft allowances Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * small description typo Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: ochikov <ochikov@users.noreply.github.com> * TokenWipe test twean and fix the version in package.json Signed-off-by: ochikov <ognyan@limechain.tech> * remove entirely hip-583 supportability Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * after build Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * new cryptography version Signed-off-by: ochikov <ognyan@limechain.tech> * used new crypto package version and update the last proto version Signed-off-by: ochikov <ognyan@limechain.tech> * new proto packages Signed-off-by: ochikov <ognyan@limechain.tech> * new packages versions Signed-off-by: ochikov <ognyan@limechain.tech> * release/2.20.0 Signed-off-by: ochikov <ognyan@limechain.tech> * export fee assessment method Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: Petar Tonev <petar.tonev@limechain.tech> * Feature nft allowance tests (#1468) * Fix _maxAutomaticTokenAssociations in contract create and contract up… (#1444) * Fix _maxAutomaticTokenAssociations in contract create and contract update transactions Signed-off-by: ochikov <ognyan@limechain.tech> * set the fields default to null Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * Feature/extend ethereumflow (#1447) * init progress Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Extend ethereum flow to accept maxChunks Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: Petar Tonev <petar.tonev@limechain.tech> * Add delete nft allowances and add delegate spender functionality (#1452) * small refactoring Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Fix/update mirror endpoints (#1448) * Fix _maxAutomaticTokenAssociations in contract create and contract up… (#1444) * Fix _maxAutomaticTokenAssociations in contract create and contract update transactions Signed-off-by: ochikov <ognyan@limechain.tech> * set the fields default to null Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * Update the mirror node endpoints Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * add missing functionalities from hip-336 nft allowances Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * small description typo Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: ochikov <ochikov@users.noreply.github.com> * TokenWipe test twean and fix the version in package.json Signed-off-by: ochikov <ognyan@limechain.tech> * remove entirely hip-583 supportability Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * after build Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * new cryptography version Signed-off-by: ochikov <ognyan@limechain.tech> * used new crypto package version and update the last proto version Signed-off-by: ochikov <ognyan@limechain.tech> * new proto packages Signed-off-by: ochikov <ognyan@limechain.tech> * new packages versions Signed-off-by: ochikov <ognyan@limechain.tech> * release/2.20.0 Signed-off-by: ochikov <ognyan@limechain.tech> * export fee assessment method Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * add tests and examples for add/remove nft allowances Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * separate nft allowance integration tests Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update test description Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ochikov@users.noreply.github.com> Co-authored-by: ochikov <ognyan@limechain.tech> * Release/hip 583 (#1472) * init hip583 Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * full support Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * fix example for nft allowances Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> * update package.json Signed-off-by: ochikov <ognyan@limechain.tech> * release/v2.22.0 Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: petreze <petar.tonev@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
monokaijs
pushed a commit
to monostarter/u2u-sdk-js
that referenced
this pull request
Jul 5, 2023
* added some supportability for hip-583 Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * added deprecation of methods and some refactoring Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * remove unused aliasEvmAddress field Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * added creation of AccountId examples Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * AccountId examples refactoring Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * init hip583 examples Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * add examples and fix tx model Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * after lint Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * almost finalized the examples, getting data from mirror node works Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * new proto package version version Signed-off-by: ochikov <ognyan@limechain.tech> * use newer version for protobufs Signed-off-by: ochikov <ognyan@limechain.tech> * proto updates and examples enhancements Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * fixed build errors Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update the proto package install task Signed-off-by: ochikov <ognyan@limechain.tech> * adjusted hip-583 examples Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * example updates and fixes Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update examples and remove unnecessary step Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * add fromEvmPublicAddress() to AccountId Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * transfer using evm address enhancements Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * fixed all of the examples plus added 2 new status codes from services Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * New proto version Signed-off-by: ochikov <ognyan@limechain.tech> * make the sdk to use new proto version Signed-off-by: ochikov <ognyan@limechain.tech> * fixed proto files Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * remove status codes, need separate branch Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * add new status codes Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * fixed lint errors after task build Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update pnpm lock files Signed-off-by: ochikov <ognyan@limechain.tech> * Update the package.json version Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/timeout issue (hiero-ledger#1414) * add new status codes (hiero-ledger#1400) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Fix the workflow for address book update and the workflow for timeout error processing Signed-off-by: ochikov <ognyan@limechain.tech> * Integration tests fixes with new account and logging of the failed address book query Signed-off-by: ochikov <ognyan@limechain.tech> * remove unused imports Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: petreze <petar.tonev@limechain.tech> * Update package.json Signed-off-by: ochikov <ognyan@limechain.tech> * Update package.json Signed-off-by: ochikov <ognyan@limechain.tech> * fix ping to throw (hiero-ledger#1426) Signed-off-by: ochikov <ognyan@limechain.tech> * Bump up dependencies (hiero-ledger#1402) * add new status codes (hiero-ledger#1400) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Bump up dependencies Signed-off-by: ochikov <ognyan@limechain.tech> * Cast the values so TS won't throw an error Signed-off-by: ochikov <ognyan@limechain.tech> * update package.json with new versions Signed-off-by: ochikov <ognyan@limechain.tech> * revert the grpc version update due to breaking changes Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: petreze <petar.tonev@limechain.tech> * removed unnecessary check Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * revert refactor Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Removed unnecessary check (hiero-ledger#1429) * removed unnecessary check Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * Update package.json of cryptography Signed-off-by: ochikov <ognyan@limechain.tech> * update the cryptography package used in the sdk Signed-off-by: ochikov <ognyan@limechain.tech> * fix integration test for topic message query Signed-off-by: ochikov <ognyan@limechain.tech> * remove the only from the failing test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> * Fix inaccurate cost calculation (hiero-ledger#1430) * fix inaccurate cost calculation Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * rename misleading comment Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * update the package version Signed-off-by: ochikov <ognyan@limechain.tech> * fix get cost and unit test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: ochikov <ognyan@limechain.tech> Co-authored-by: Petar Tonev <petar.tonev@limechain.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petar Tonev petar.tonev@limechain.tech
Description:
This PR removes an unnecessary check if a transaction is frozen
Related issue(s):
Fixes #
Notes for reviewer:
Previously we were performing a check if a transaction is frozen and throwing an error if its not. This check is not needed as right after the check, we automatically freeze the transaction if its not
Checklist