KeyList now handles single key properly as first parameter #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
petreze
requested review from
janaakhterov,
mehcode and
SimiHunjan
as code owners
|
SonarCloud Quality Gate failed.
|
Codecov ReportBase: 83.45% // Head: 83.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1348 +/- ##
===========================================
+ Coverage 83.45% 83.47% +0.02%
===========================================
Files 292 292
Lines 72847 72854 +7
===========================================
+ Hits 60791 60816 +25
+ Misses 12056 12038 -18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ochikov
approved these changes
Dec 5, 2022
monokaijs
pushed a commit
to monostarter/u2u-sdk-js
that referenced
this pull request
Jul 5, 2023
…edger#1348) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petar Tonev petar.tonev@limechain.tech
Description:
There was an issue when passing a single key object as a first parameter to
KeyList, since the SDK could not proceed when getting a non-list value. Now the SDK acts properly in these casesRelated issue(s):
Fixes #1343
Notes for reviewer:
Added some checks and proper handles based on parameter
Checklist