Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add left padding of 0s to the transactionId nanoseconds #1388

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

dikel
Copy link
Contributor

@dikel dikel commented Apr 25, 2023

Description:
Adds left padding of 0s to the transactionId nanoseconds

Related issue(s):

Fixes #1387

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: dikel <dikelito@tutamail.com>
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14 ⚠️

Comparison is base (d188fcc) 81.37% compared to head (fb4d1ca) 81.23%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1388      +/-   ##
=============================================
- Coverage      81.37%   81.23%   -0.14%     
+ Complexity      3452     3441      -11     
=============================================
  Files            183      183              
  Lines          11482    11482              
  Branches        1129     1129              
=============================================
- Hits            9343     9327      -16     
- Misses          1670     1679       +9     
- Partials         469      476       +7     
Impacted Files Coverage Δ
...n/java/com/hedera/hashgraph/sdk/TransactionId.java 69.16% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: dikel <dikelito@tutamail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dikel dikel requested a review from petreze April 26, 2023 07:44
@dikel dikel merged commit ca5e9bc into develop Apr 26, 2023
@dikel dikel deleted the fix/transactionId-nanoseconds-zero-padding branch April 26, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransactionId toString not returning the same value as the mirror nodes
2 participants