Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle docker file sharing permissions on start-up #830

Merged

Conversation

natanasow
Copy link
Contributor

@natanasow natanasow commented Nov 6, 2024

Description:

Running a docker compose up -d in a new setup resulted in a

Error response from daemon: Mounts denied:
The path .../hedera-local-node/envoy.yaml is not shared from the host and is not known to Docker.
You can configure shared paths from Docker -> Preferences... -> Resources -> File Sharing.
See https://docs.docker.com/desktop/settings/mac/#file-sharing for more info.

Solution:

  • - add a startup check for docker file-sharing permissions
  • - add a section to the current README.md

Related issue(s):

Fixes #818, #819

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow self-assigned this Nov 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.49%. Comparing base (067415f) to head (22be948).

Files with missing lines Patch % Lines
src/services/DockerService.ts 16.66% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   63.72%   63.49%   -0.24%     
==========================================
  Files          30       30              
  Lines        1213     1219       +6     
  Branches      145      146       +1     
==========================================
+ Hits          773      774       +1     
- Misses        419      424       +5     
  Partials       21       21              
Files with missing lines Coverage Δ
src/constants.ts 100.00% <100.00%> (ø)
src/services/DockerService.ts 9.09% <16.66%> (-0.33%) ⬇️

Impacted file tree graph

Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow marked this pull request as ready for review November 7, 2024 11:42
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Copy link

sonarqubecloud bot commented Nov 7, 2024

@natanasow natanasow merged commit ea6fc5b into main Nov 8, 2024
14 checks passed
@natanasow natanasow deleted the 818-819-handle-docker-file-sharing-permissions-on-startup branch November 8, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startup fails to connect to port 5600
4 participants