Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Docker resources check on Windows #808

Merged

Conversation

Ivo-Yankov
Copy link
Contributor

@Ivo-Yankov Ivo-Yankov commented Oct 25, 2024

Description:
Fixes an error that occurs on Windows during startup.

SyntaxError: Unexpected end of JSON input

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.59%. Comparing base (6cf8ec3) to head (5dcf2d8).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/services/DockerService.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   57.59%   57.59%           
=======================================
  Files          30       30           
  Lines        1403     1403           
  Branches      173      173           
=======================================
  Hits          808      808           
  Misses        574      574           
  Partials       21       21           
Files with missing lines Coverage Δ
src/services/DockerService.ts 9.42% <0.00%> (ø)

Impacted file tree graph

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Ivo-Yankov Ivo-Yankov self-assigned this Oct 25, 2024
@Ivo-Yankov Ivo-Yankov linked an issue Oct 25, 2024 that may be closed by this pull request
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Copy link

@Ivo-Yankov Ivo-Yankov changed the title fix: Docker resources check on Windows Server 2022 fix: Docker resources check on Windows Oct 29, 2024
@Ivo-Yankov Ivo-Yankov added Bug An error that causes the feature to behave differently than what was expected based on design. Docker Feature that impacts docker labels Oct 29, 2024
@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review October 29, 2024 15:19
@Ivo-Yankov Ivo-Yankov merged commit 1965dbe into main Oct 30, 2024
16 of 17 checks passed
@Ivo-Yankov Ivo-Yankov deleted the 806-docker-resources-check-fails-on-windows-server-2022 branch October 30, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Docker Feature that impacts docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker resources check fails on Windows Server 2022
4 participants