Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve log verbosity #577

Merged
merged 6 commits into from
Jul 25, 2024
Merged

chore: Improve log verbosity #577

merged 6 commits into from
Jul 25, 2024

Conversation

Ivo-Yankov
Copy link
Contributor

@Ivo-Yankov Ivo-Yankov commented Apr 4, 2024

Description:

  • Adds the output of the externally executed commands in DockerService to the debug level of logs.
  • Reduces the repeated error logs when waiting for a service to start up.

Related issue(s):

Fixes #412

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Ivo-Yankov Ivo-Yankov self-assigned this Apr 4, 2024
@Ivo-Yankov Ivo-Yankov linked an issue Apr 4, 2024 that may be closed by this pull request
@Ivo-Yankov Ivo-Yankov added the Improvement Code changes driven by non business requirements. label Apr 4, 2024
@Ivo-Yankov Ivo-Yankov marked this pull request as draft April 4, 2024 13:55
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 17.24138% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 50.79%. Comparing base (d34c153) to head (e89a4f0).

Files Patch % Lines
src/services/DockerService.ts 0.00% 12 Missing ⚠️
src/utils/debounce.ts 22.22% 7 Missing ⚠️
src/services/ConnectionService.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   51.39%   50.79%   -0.61%     
==========================================
  Files          24       25       +1     
  Lines        1181     1201      +20     
  Branches      136      138       +2     
==========================================
+ Hits          607      610       +3     
- Misses        550      567      +17     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ivo-Yankov Ivo-Yankov changed the title feat: Improve log verbosity feat: improve log verbosity Apr 5, 2024
Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review April 5, 2024 09:21
@Ivo-Yankov Ivo-Yankov changed the title feat: improve log verbosity feat: Improve log verbosity Apr 8, 2024
@Ivo-Yankov Ivo-Yankov changed the title feat: Improve log verbosity feat: Improve log verbosityy May 22, 2024
@Ivo-Yankov Ivo-Yankov changed the title feat: Improve log verbosityy chore: Improve log verbosity May 22, 2024
Ivo-Yankov and others added 5 commits July 22, 2024 08:48
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
konstantinabl
konstantinabl previously approved these changes Jul 24, 2024
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Copy link

@isavov isavov merged commit 52dc948 into main Jul 25, 2024
9 checks passed
@isavov isavov deleted the 412-verbose-docker-output branch July 25, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements. Limechain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a verbose option when starting up
4 participants