Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options for custom tags #526

Merged

Conversation

georgi-l95
Copy link
Member

Description:
This PR adds 3 new options for selecting custom images for network, mirror-node and/or relay. This will allow for easier testing with different tags in CI.

Related issue(s):

Fixes #525

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 requested a review from isavov January 29, 2024 18:29
@georgi-l95 georgi-l95 self-assigned this Jan 29, 2024
@georgi-l95 georgi-l95 linked an issue Jan 29, 2024 that may be closed by this pull request
isavov
isavov previously approved these changes Jan 29, 2024
Copy link
Contributor

@isavov isavov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@georgi-l95 georgi-l95 merged commit bbdc9de into main Jan 30, 2024
11 checks passed
@georgi-l95 georgi-l95 deleted the 525-add-options-to-start-local-node-with-desired-configuration branch January 30, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add options to start local node with desired configuration
2 participants