feat: allow setting of working directory #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isavov
added
Bug
isavov
force-pushed
the
308-local-node-requires-sudo-privileges
branch
from
4f0928f to
c4dd26d
Compare
isavov
requested review from
georgi-l95,
konstantinabl,
Ivo-Yankov,
natanasow and
stefan-stefanooov
georgi-l95
reviewed
Jan 3, 2024
isavov
force-pushed
the
308-local-node-requires-sudo-privileges
branch
from
f998b5a to
4f8dfee
Compare
stefan-stefanooov
suggested changes
Jan 3, 2024
stefan-stefanooov
approved these changes
Jan 4, 2024
konstantinabl
requested changes
Jan 4, 2024
| type: 'string', | ||
| describe: 'Path to the working directory for local node', | ||
| demandOption: false, | ||
| default: FileSystemUtils.getPlatformSpecificAppDataPath('hedera-local') |
There was a problem hiding this comment.
Shouldnt this be hedera-local-node instead of hedera-local
There was a problem hiding this comment.
I've chosen hedera-local because the official npm package name is @hashgraph/hedera-local, we might want to set it to something else, I'm open to suggestions
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
isavov
force-pushed
the
308-local-node-requires-sudo-privileges
branch
from
14e737d to
d06b889
Compare
|
natanasow
approved these changes
Jan 8, 2024
konstantinabl
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR allows setting of the working directory where local node writes its ephemeral data which can be set using the
--workdirflag, and has a default value dependant on the OS of the user~/Library/Application Support/hedera-local~/.local/share/hedera-local%USERPROFILE%\AppData\Local\hedera-localRelated issue(s):
Fixes #308
Notes for reviewer:
Checklist