Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker Check error #350

Merged

Conversation

georgi-l95
Copy link
Member

Description:
In some cases we check for the images version, before they are started, therefore this results in an error. This PR fixes this by setting the version to Unknown and afterwards updating it to the actual when the containers are started.
Also fixes issue when starting normal mode (not detached)

Related issue(s):

Fixes #347

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 added the Bug An error that causes the feature to behave differently than what was expected based on design. label Jun 28, 2023
@georgi-l95 georgi-l95 self-assigned this Jun 28, 2023
@georgi-l95 georgi-l95 linked an issue Jun 28, 2023 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@isavov isavov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgi-l95 georgi-l95 merged commit a996717 into main Jun 29, 2023
@georgi-l95 georgi-l95 deleted the 347-cannot-read-properties-of-undefined-reading-image branch June 29, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'Image')
2 participants