Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user Compose definitions #331

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

isavov
Copy link
Contributor

@isavov isavov commented May 9, 2023

Description:
This PR adds two new cli options
--usercompose with a default value of true, which enables/disables support for user Compose definitions
--composedir with a default value of "./overrides" which defines the directory containing the desired user Compose definitions
When the option is enabled it loads all of the files in the specified directory in alphabetical order as additional Compose definitions allowing the user to modify the default local node setup.

  • Add cli options

Related issue(s):

Fixes #330

Notes for reviewer:
Here's an example of a custom Compose definition, that disables prometheus and grafana it can be put in a file with ".yml" extension in a overrides directory at the root of the project to test

services:
  grafana:
    profiles:
      - disabled
  prometheus:
    profiles:
      - disabled

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@isavov isavov added New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. Docker Feature that impacts docker labels May 9, 2023
@isavov isavov requested review from Ivo-Yankov and georgi-l95 May 9, 2023 10:38
@isavov isavov self-assigned this May 9, 2023
@isavov isavov linked an issue May 9, 2023 that may be closed by this pull request
@isavov isavov requested a review from natanasow May 9, 2023 10:39
isavov added 2 commits May 25, 2023 15:42
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Handle trialing slashes

Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
@isavov isavov force-pushed the 330-add-support-for-user-compose-definitions branch from ef48bc8 to 9d22c42 Compare May 25, 2023 12:45
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@isavov isavov merged commit 614a699 into main Jun 7, 2023
@isavov isavov deleted the 330-add-support-for-user-compose-definitions branch June 7, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Feature that impacts docker New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for user Compose definitions
2 participants