Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HBAR Limiter #241

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Fix HBAR Limiter #241

merged 2 commits into from
Dec 5, 2022

Conversation

georgi-l95
Copy link
Member

@georgi-l95 georgi-l95 commented Dec 2, 2022

Signed-off-by: georgi-l95 glazarov95@gmail.com

Description:
Fix hbar limiter to be disabled, when limits option is false

Related issue(s):

Fixes #239

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 marked this pull request as ready for review December 2, 2022 16:18
@georgi-l95 georgi-l95 requested a review from natanasow December 2, 2022 16:18
@mshakeg
Copy link

mshakeg commented Dec 4, 2022

Can the eth_call rate limits(and any other rate limits) also be disabled if --limits=false

@georgi-l95
Copy link
Member Author

Can the eth_call rate limits(and any other rate limits) also be disabled if --limits=false

I will look into it, but if there's a bug, that would probably require a change in the relay, not here.

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HBAR Rate limit exceeded error
3 participants