our vertx grpc raises statusruntimeexceptions not grpcexceptions

hiddenswitch · Dec 11, 2024 · 0efe5a3 · 0efe5a3
1 parent 8da3679
commit 0efe5a3
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 6 deletions.
diff --git a/vertx-grpc/vertx-grpc-client/build.gradle b/vertx-grpc/vertx-grpc-client/build.gradle
@@ -52,6 +52,10 @@ dependencies {
   protocPlugin project(path: ':vertx-grpc:vertx-grpc-protoc-plugin2', configuration: 'shadow')
 }
 
+test {
+  dependsOn "generateProto"
+}
+
 protobuf {
   protoc {
     artifact = "com.google.protobuf:protoc:3.25.5"

diff --git a/vertx-grpc/vertx-grpc-it/build.gradle b/vertx-grpc/vertx-grpc-it/build.gradle
@@ -44,6 +44,10 @@ dependencies {
 }
 
 
+test {
+  dependsOn "generateProto"
+}
+
 protobuf {
   protoc {
     artifact = "com.google.protobuf:protoc:3.25.5"

diff --git a/vertx-grpc/vertx-grpc-it/src/test/java/io/vertx/grpc/it/ProtocPluginTest.java b/vertx-grpc/vertx-grpc-it/src/test/java/io/vertx/grpc/it/ProtocPluginTest.java
@@ -11,6 +11,8 @@
 package io.vertx.grpc.it;
 
 import com.google.protobuf.ByteString;
+import io.grpc.Status;
+import io.grpc.StatusRuntimeException;
 import io.grpc.examples.helloworld.HelloReply;
 import io.grpc.examples.helloworld.HelloRequest;
 import io.grpc.examples.helloworld.VertxGreeterGrpcClient;
@@ -397,9 +399,9 @@ public ReadStream<Messages.StreamingOutputCallResponse> streamingOutputCall(Mess
       .build();
     client.streamingOutputCall(request)
       .onComplete(should.asyncAssertFailure(err -> {
-        should.assertTrue(err instanceof GrpcException);
-        GrpcException grpcException = (GrpcException)err;
-        should.assertEquals(GrpcStatus.INTERNAL, grpcException.status());
+        should.assertTrue(err instanceof StatusRuntimeException);
+        var grpcException = (StatusRuntimeException)err;
+        should.assertEquals(Status.INTERNAL.getCode(), grpcException.getStatus().getCode());
         test.complete();
       }));
     test.awaitSuccess();
@@ -532,9 +534,9 @@ public ReadStream<Messages.StreamingOutputCallResponse> fullDuplexCall(ReadStrea
         req.end();
       })
       .onComplete(should.asyncAssertFailure(err -> {
-        should.assertTrue(err instanceof GrpcException);
-        GrpcException grpcException = (GrpcException)err;
-        should.assertEquals(GrpcStatus.INTERNAL, grpcException.status());
+        should.assertTrue(err instanceof StatusRuntimeException);
+        var grpcException = (StatusRuntimeException)err;
+        should.assertEquals(io.grpc.Status.INTERNAL.getCode(), grpcException.getStatus().getCode());
         test.complete();
       }));
     test.awaitSuccess();

diff --git a/vertx-grpc/vertx-grpc-server/build.gradle b/vertx-grpc/vertx-grpc-server/build.gradle
@@ -66,6 +66,10 @@ dependencies {
 
 }
 
+test {
+  dependsOn "generateProto"
+}
+
 protobuf {
   protoc {
     artifact = "com.google.protobuf:protoc:3.25.5"