Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strain_optimization.py #384

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Update strain_optimization.py #384

merged 1 commit into from
Dec 17, 2023

Conversation

mbkumar
Copy link
Collaborator

@mbkumar mbkumar commented Dec 6, 2023

Update some parameters in the strain optimization example as per Paul suggestion. Add credit to Paul Huslage in examples/strain_optimization.py due to missing git commit history.

Update some parameters in the strain optimization example. 
Give credit to Paul Huslage
@mbkumar mbkumar requested a review from ejpaul December 6, 2023 23:37
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50f41d6) 91.43% compared to head (39ca311) 91.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   91.43%   91.07%   -0.37%     
==========================================
  Files          73       73              
  Lines       12709    12709              
==========================================
- Hits        11621    11575      -46     
- Misses       1088     1134      +46     
Flag Coverage Δ
unittests 91.07% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@landreman landreman self-requested a review December 17, 2023 03:48
@mbkumar mbkumar merged commit d95a479 into master Dec 17, 2023
45 of 47 checks passed
@mbkumar mbkumar deleted the mbkumar-patch-1 branch December 17, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants