Make linting more rigorous. #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 91.38% 91.40% +0.01%
==========================================
Files 72 72
Lines 12700 12659 -41
==========================================
- Hits 11606 11571 -35
+ Misses 1094 1088 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
landreman
previously approved these changes
Oct 24, 2023
|
@landreman |
|
@landreman |
landreman
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to expand the linting rule list to catch more issues. At the same time, I'd like to update the linting framework to the one based on ruff. In place of pep8 and flake8 tools, we will use ruff.
To use ruff, run
pip install rufffollowed by./run_ruff.The configuration for ruff is done in pyproject.toml. The linter workflow is updated to use ruff. If you are satisfied, I can commit the fixes by ruff and do one more push with all the changes to the source code.