Fix reference cycles between python and C++ #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ually by holding a reference to it See pybind/pybind11#1389 for why py_shared_ptr was needed in the first place, and the comment from May 27 why we may not want to use it (reference cycle)
florianwechsung
force-pushed
the
fw/no_py_shared_ptr
branch
from
2b40a3a
to
23bb44d
Compare
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 90.08% 90.08%
=======================================
Files 55 55
Lines 6081 6082 +1
=======================================
+ Hits 5478 5479 +1
Misses 603 603
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mbkumar
approved these changes
Oct 2, 2021
|
Thanks @florianwechsung |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kick out py_shared_ptr and instead keep the python instance alive manually by holding a reference to it
See pybind/pybind11#1389 for why py_shared_ptr was needed in the first place, and the comment from May 27 why we may not want to use it (reference cycle)