Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added logic to add redirect url w custom domain #9402

Merged
merged 3 commits into from
Oct 3, 2024
Merged

added logic to add redirect url w custom domain #9402

merged 3 commits into from
Oct 3, 2024

Conversation

Israellund
Copy link
Collaborator

Link to Issue

Closes: #9372

Description of Changes

  • added logic to add a redirect url to the allowlist along with the custom domain, within the admin panel.

Test Plan

@kurtisassad will test with his personal Magic account to see if this hits the correct endpoint

kurtisassad
kurtisassad approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@kurtisassad kurtisassad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets get this in.

@ilijabojanovic ilijabojanovic self-requested a review October 3, 2024 16:25
@ilijabojanovic ilijabojanovic merged commit 38cde77 into master Oct 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilijabojanovic ilijabojanovic ilijabojanovic approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add domain to Magic redirect list in custom domain within admin panel
3 participants
@Israellund @ilijabojanovic @kurtisassad