Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Balances Route for Commonbot #2073

Merged
merged 19 commits into from
Sep 21, 2022
Merged

Bulk Balances Route for Commonbot #2073

merged 19 commits into from
Sep 21, 2022

Conversation

alexyoung23j
Copy link
Contributor

@alexyoung23j alexyoung23j commented Aug 18, 2022

Description

Route provides token balance information for a user ID across specified chain nodes and token addresses.

Motivation and Context

For Commonbot!

How has this been tested?

Tested locally.

Does this PR affect any server routes?

  • yes
  • no

If this PR affects server routes, what are the security implications?

Have proper tags been added (for bug, enhancement, breaking change)?

  • yes

@alexyoung23j alexyoung23j added the 5 Few days task label Aug 18, 2022
@alexyoung23j alexyoung23j self-assigned this Aug 18, 2022
@zakhap zakhap changed the title Bulk Balances Route for Commonbot WIP: Bulk Balances Route for Commonbot Aug 23, 2022
@alexyoung23j alexyoung23j requested a review from dillchen as a code owner August 29, 2022 21:11
@alexyoung23j alexyoung23j changed the title WIP: Bulk Balances Route for Commonbot Bulk Balances Route for Commonbot Aug 30, 2022
Copy link
Collaborator

@jnaviask jnaviask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments -- no major changes needed, need to QA still.

Copy link
Collaborator

@zakhap zakhap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as a V1 to begin end-to-end testing. Still has work to do, but onwards and upwards 🚀

@zakhap zakhap merged commit d19eae5 into master Sep 21, 2022
@zakhap zakhap deleted the alex.bulk-balances-route branch September 21, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Few days task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants