Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Redis client to v9 #303

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

trungdlp-wolffun
Copy link
Contributor

@trungdlp-wolffun trungdlp-wolffun commented May 4, 2023

Version 9.0.4 implements the support for Redis v7.

Changelog of redis/go-redis can be found here: https://github.com/redis/go-redis/blob/master/CHANGELOG.md

hibiken/asynq#627

Fixed issue: #302

@trungdlp-wolffun
Copy link
Contributor Author

@kamikazechaser help me review this PR, please 😁

@trungdlp-wolffun
Copy link
Contributor Author

@hibiken 🥺

Copy link

@kamikazechaser kamikazechaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trungdlp-wolffun
Copy link
Contributor Author

@hibiken please review this PR 🚶

Copy link
Owner

@hibiken hibiken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (sorry for the delay)

@hibiken hibiken merged commit e44ba43 into hibiken:master Jul 3, 2023
@lukasmalkmus
Copy link
Contributor

LGTM! (sorry for the delay)

No need to apologise! OSS maintainers have a life, too :)

I usually ping/ack/act on OSS issues/PRs because GitHub notifications can be overwhelming and are not very effective to manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants