Feat/dynamic queue with concurrency #973
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmid
force-pushed
the
feat/dynamic_queue_with_concurrency
branch
from
541a69a to
2bace4c
Compare
pcmid
changed the title
pcmid
changed the title
|
any updates on this? where are we right now? |
This is a major feature. It could land on a testing branch for a few months before we release it on master just to smoke out any bugs. Also see the comments left by the linter. It would be good to also have feedback from @kanzihuang (if he is around). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented #250, based on #879, cc @kanzihuang, with support for dynamically adding queues and controlling concurrency levels.
Not fully verified, but it works perfectly for my use case: a distributed spider with concurrency control.
Known issues: