[Draft] to fix "java.lang.IllegalStateException: Session/EntityManager is closed"

[Sanne]

Relates to quarkusio/quarkus#22433 and #1073

@DavideD

[DavideD]

I've tested it and it seems to also fix #1073

[gavinking]

Oh, right, fine, this undoes the thing I just noticed.

I think we should definitely merge this. If i understand correctly, the change made in https://github.com/hibernate/hibernate-reactive/pull/948/files would cause the Hibernate session and transaction between all threads in a verticle. If that's right, then no wonder users were running into concurrency problems.

[gavinking]

I'm going to just merge this.

[DavideD]

@gavinking, Please, check with us before merging things that are in draft
and assigned to somebody else

[gavinking]

Um. No, I don't think that's a reasonable thing to yell at me about. The change to use put() and get() instead of putLocal() and getLocal() was clearly wrong, and certainly unintended. I know because this is code I originally wrote and I know what it's supposed to do.

And the change that broke it broke Hibernate Reactive for essentially every user. It's extremely embarrassing that we have not noticed this issue since September, and have had multiple users report multiple bugs that I assume stem from this, and we have not done anything about it until now.

So, yeah, my fault for being swapped out, for sure, but right now we need to prioritize the fuck out of getting this fix out into a release, not keep sitting around fiddling and twiddling our fingers and worrying what process is followed when merging fixes to serious bugs!

[gavinking]

Seriously, we should have been on top of this way earlier and we weren't.

We need to be feeling quite bad about this right now.

[Sanne]

We need to be feeling quite bad about this right now.

Don't worry, I felt quite bad when I realized my mistake.

But there's no reason to rush things as we won't be able to release until tomorrow the earliest.