HHH-14326 + HHH-14404 Connection closing fixes #3693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
…s fails Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
… SessionBuilder Signed-off-by: Yoann Rodière <yoann@hibernate.org>
…ilder Signed-off-by: Yoann Rodière <yoann@hibernate.org>
This was referenced Jan 14, 2021
Sanne
reviewed
Jan 19, 2021
...te-core/src/main/java/org/hibernate/resource/jdbc/internal/LogicalConnectionManagedImpl.java
Outdated
Show resolved
Hide resolved
…anagedImpl#releaseConnection It's unlikely to ever happen, and even if it happened, the resulting exception would probably be rather clear about the fact that the problem is related to concurrent execution (ConcurrentModificationException thrown by a Map of resources, for example). See hibernate#3693 (comment) Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Sanne
reviewed
Jan 20, 2021
hibernate-core/src/test/java/org/hibernate/test/connections/BeforeCompletionReleaseTest.java
Show resolved
Hide resolved
Sanne
pushed a commit
that referenced
this pull request
Jan 20, 2021
…anagedImpl#releaseConnection It's unlikely to ever happen, and even if it happened, the resulting exception would probably be rather clear about the fact that the problem is related to concurrent execution (ConcurrentModificationException thrown by a Map of resources, for example). See #3693 (comment) Signed-off-by: Yoann Rodière <yoann@hibernate.org>
|
great, merged it in master, checking backports now.. |
|
Thanks! |
Sanne
pushed a commit
that referenced
this pull request
Jan 20, 2021
…anagedImpl#releaseConnection It's unlikely to ever happen, and even if it happened, the resulting exception would probably be rather clear about the fact that the problem is related to concurrent execution (ConcurrentModificationException thrown by a Map of resources, for example). See #3693 (comment) Signed-off-by: Yoann Rodière <yoann@hibernate.org>
|
all merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for quarkusio/quarkus#13273 and quarkusio/quarkus#7242 in particular.