Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-14326 + HHH-14404 Connection closing fixes #3693

Closed
wants to merge 6 commits into from

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Jan 14, 2021

  • HHH-14404: SessionBuilder.connectionHandlingMode is ignored
  • HHH-14326: StoredProcedureQuery instances should be closed by Hibernate ORM

Necessary for quarkusio/quarkus#13273 and quarkusio/quarkus#7242 in particular.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
…s fails

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
… SessionBuilder

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
…ilder

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
…anagedImpl#releaseConnection

It's unlikely to ever happen, and even if it happened, the resulting
exception would probably be rather clear about the fact that the problem
is related to concurrent execution (ConcurrentModificationException
thrown by a Map of resources, for example).

See
hibernate#3693 (comment)

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Sanne pushed a commit that referenced this pull request Jan 20, 2021
…anagedImpl#releaseConnection

It's unlikely to ever happen, and even if it happened, the resulting
exception would probably be rather clear about the fact that the problem
is related to concurrent execution (ConcurrentModificationException
thrown by a Map of resources, for example).

See
#3693 (comment)

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
@Sanne
Copy link
Member

Sanne commented Jan 20, 2021

great, merged it in master, checking backports now..

@yrodiere
Copy link
Member Author

Thanks!

Sanne pushed a commit that referenced this pull request Jan 20, 2021
…anagedImpl#releaseConnection

It's unlikely to ever happen, and even if it happened, the resulting
exception would probably be rather clear about the fact that the problem
is related to concurrent execution (ConcurrentModificationException
thrown by a Map of resources, for example).

See
#3693 (comment)

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
@Sanne
Copy link
Member

Sanne commented Jan 20, 2021

all merged

@Sanne Sanne closed this Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants