HHH-14900 No need in tests to shadow the jdbcBatchSize field of Batch…

…BuilderImpl extensions
hibernate · Oct 26, 2021 · 5ad60c4 · 5ad60c4
1 parent aba67cf
commit 5ad60c4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 21 deletions.
diff --git a/...-core/src/test/java/org/hibernate/jpa/test/transaction/batch/JtaWithFailingBatchTest.java b/...-core/src/test/java/org/hibernate/jpa/test/transaction/batch/JtaWithFailingBatchTest.java
@@ -151,16 +151,10 @@ protected String getBatchBuilderClassName() {
 	}
 
 	public static class TestBatchBuilder extends BatchBuilderImpl {
-		private int jdbcBatchSize;
-
-		@Override
-		public void setJdbcBatchSize(int jdbcBatchSize) {
-			this.jdbcBatchSize = jdbcBatchSize;
-		}
 
 		@Override
 		public Batch buildBatch(BatchKey key, JdbcCoordinator jdbcCoordinator) {
-			return buildBatchTest( key, jdbcCoordinator, jdbcBatchSize );
+			return buildBatchTest( key, jdbcCoordinator, getJdbcBatchSize() );
 		}
 
 		protected BatchingBatch buildBatchTest(BatchKey key, JdbcCoordinator jdbcCoordinator, int jdbcBatchSize) {

diff --git a/...re/src/test/java/org/hibernate/jpa/test/transaction/batch/JtaWithStatementsBatchTest.java b/...re/src/test/java/org/hibernate/jpa/test/transaction/batch/JtaWithStatementsBatchTest.java
@@ -127,16 +127,10 @@ protected String getBatchBuilderClassName() {
 	}
 
 	public static class TestBatchBuilder extends BatchBuilderImpl {
-		private int jdbcBatchSize;
-
-		@Override
-		public void setJdbcBatchSize(int jdbcBatchSize) {
-			this.jdbcBatchSize = jdbcBatchSize;
-		}
 
 		@Override
 		public Batch buildBatch(BatchKey key, JdbcCoordinator jdbcCoordinator) {
-			return buildBatchTest( key, jdbcCoordinator, jdbcBatchSize );
+			return buildBatchTest( key, jdbcCoordinator, getJdbcBatchSize() );
 		}
 
 		protected BatchingBatch buildBatchTest(BatchKey key, JdbcCoordinator jdbcCoordinator, int jdbcBatchSize) {

diff --git a/hibernate-core/src/test/java/org/hibernate/test/insertordering/InsertOrderingTest.java b/hibernate-core/src/test/java/org/hibernate/test/insertordering/InsertOrderingTest.java
@@ -109,16 +109,10 @@ public void addToBatch() {
 	}
 
 	public static class StatsBatchBuilder extends BatchBuilderImpl {
-		private int jdbcBatchSize;
-
-		@Override
-        public void setJdbcBatchSize(int jdbcBatchSize) {
-			this.jdbcBatchSize = jdbcBatchSize;
-		}
 
 		@Override
 		public Batch buildBatch(BatchKey key, JdbcCoordinator jdbcCoordinator) {
-			return new StatsBatch( key, jdbcCoordinator, jdbcBatchSize );
+			return new StatsBatch( key, jdbcCoordinator, getJdbcBatchSize() );
 		}
 	}
 }