Problem with ArrayTypeDetailsImpl#getName

[cigaly]

Attached is test case that is failing
MultiDimensionalIntegerArrayTypeTest.txt

I've noticed it while testing something on Hibernate ORM, but the problem seems to be in org.hibernate.models.internal.ArrayTypeDetailsImpl#getName. When run, test is failing with message

org.opentest4j.AssertionFailedError: Returned class ==> expected: <int[][][][]> but was: <int[][][][][][][][][][]>

Source of the problem is inside the loop:

		while ( type.getTypeKind() == Kind.ARRAY ) {
			int dimensions = type.asArrayType().getDimensions();
			while ( dimensions-- > 0 ) {
				builder.append( '[' );
			}
			type = type.asArrayType().getConstituentType();
		}

This way, number of dimensions in returned class will be d*(d+1)/2 instead of just d since every constituent type has dimension one less that its 'parent'

Correct code should be imply:

		while ( type.getTypeKind() == Kind.ARRAY ) {
			builder.append( '[' );
			type = type.asArrayType().getConstituentType();
		}

[sebersole]

Thanks @cigaly !

Do you agree to let me use that test in this project (different licenses)?

[cigaly]

Yes, of course

[sebersole]

Thanks! Sorry to ask, but its important to have explicit approval :)

[sebersole]

Fixed