spotless

build.gradle

@@ -1,6 +1,7 @@
 plugins {
 	id "io.github.gradle-nexus.publish-plugin"
 	id "release-process"
+	id 'com.diffplug.spotless' version '6.25.0' apply false
 }
 
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

buildSrc/src/main/groovy/java-module.gradle

@@ -2,7 +2,9 @@ plugins {
 	id "base-information"
 	id "java-library"
 
+	id "com.diffplug.spotless"
 	id "checkstyle"
+
 	id "jacoco"
 }
 
@@ -50,6 +52,9 @@ tasks.withType( JavaCompile ).configureEach {javaCompile->
 	options.warnings false
 }
 
+tasks.named( "checkstyleMain" ) {
+	dependsOn( tasks.named( "spotlessJavaApply" ) )
+}
 
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 // Javadoc
@@ -72,6 +77,23 @@ tasks.named( "javadoc", Javadoc ) {
 }
 
 
+// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+// Spotless
+// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+spotless {
+	//Don't fail during the check: rather than enforcing guidelines, we use this plugin to fix mistakes automatically.
+	enforceCheck false
+	java {
+		licenseHeaderFile rootProject.file( 'config/spotless/license.java' )
+		removeUnusedImports()
+		indentWithTabs( 4 )
+		trimTrailingWhitespace()
+		endWithNewline()
+	}
+}
+
+
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 // Checkstyle
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

config/checkstyle/checkstyle.xml

@@ -8,49 +8,20 @@
 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.1//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
 <module name="Checker">
 
-    <module name="Header">
-        <property name="headerFile" value="${config_loc}/headers/header-java.txt"/>
-        <property name="fileExtensions" value="java,gradle,groovy"/>
-    </module>
-
-    <module name="Header">
-        <property name="headerFile" value="${config_loc}/headers/header-xml.txt"/>
-        <property name="fileExtensions" value="xml,xsd,xjb"/>
-    </module>
-
     <module name="TreeWalker">
-        <module name="RegexpSinglelineJava">
-            <property name="ignoreComments" value="true" />
-            <property name="format" value="^\t* +\t*\S" />
-            <property name="message" value="Line has leading space characters; indentation should be performed with tabs only." />
-        </module>
-
-        <module name="Regexp">
-            <property name="format" value="/^(master|slave)$/"/>
-            <property name="illegalPattern" value="true"/>
-            <property name="message" value="Conscious Language (use of terms 'master' or 'slave' not allowed)"/>
-        </module>
-
         <module name="MissingDeprecated" />
-
         <module name="MissingOverride" />
 
-        <module name="PackageAnnotation" />
-
         <module name="NeedBraces" />
-
         <module name="LeftCurly">
             <property name="option" value="eol" />
         </module>
-
         <module name="RightCurly">
             <property name="option" value="alone" />
         </module>
 
         <module name="EqualsHashCode" />
-
         <module name="StringLiteralEquality" />
-
         <module name="NoFinalizer" />
 
         <module name="OneStatementPerLine" />

config/spotless/license.java

@@ -0,0 +1,4 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ * Copyright: Red Hat Inc. and Hibernate Authors
+ */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/AbstractAnnotationTarget.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/AbstractValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/AnnotationUsageBuilder.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/ArrayValueConverter.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/ArrayValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/BooleanValueConverter.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/BooleanValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/ByteValueConverter.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/ByteValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/CharacterValueConverter.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/CharacterValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/ClassValueConverter.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/ClassValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/DoubleValueConverter.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/DoubleValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/EnumValueConverter.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/EnumValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/FloatValueConverter.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/FloatValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/IntegerValueConverter.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/IntegerValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexAnnotationDescriptorImpl.java

@@ -1,10 +1,7 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */
-
 package org.hibernate.models.jandex.internal;
 
 import java.lang.annotation.Annotation;

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexAnnotationDescriptorRegistry.java

@@ -1,10 +1,7 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */
-
 package org.hibernate.models.jandex.internal;
 
 import java.lang.annotation.Annotation;

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexBuilders.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexClassDetails.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexClassDetailsBuilderImpl.java

@@ -1,10 +1,7 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */
-
 package org.hibernate.models.jandex.internal;
 
 import org.hibernate.models.spi.ClassDetails;

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexClassDetailsRegistry.java

@@ -1,10 +1,7 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */
-
 package org.hibernate.models.jandex.internal;
 
 import org.hibernate.models.UnknownClassException;

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexFieldDetails.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexIndexerHelper.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexMethodDetails.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexModelBuildingContextImpl.java

@@ -1,10 +1,7 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */
-
 package org.hibernate.models.jandex.internal;
 
 import java.util.HashMap;

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexNestedValueConverter.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexNestedValueExtractor.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexRecordComponentDetails.java

@@ -1,6 +1,4 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexTypeSwitchStandard.java

@@ -1,10 +1,7 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */
-
 package org.hibernate.models.jandex.internal;
 
 import java.lang.reflect.InvocationTargetException;

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexTypeSwitcher.java

@@ -1,10 +1,7 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */
-
 package org.hibernate.models.jandex.internal;
 
 import org.hibernate.models.jandex.spi.JandexTypeSwitch;

hibernate-models-jandex/src/main/java/org/hibernate/models/jandex/internal/JandexValueHelper.java

@@ -1,10 +1,7 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */
-
 package org.hibernate.models.jandex.internal;
 
 import java.lang.annotation.Annotation;