Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(next)!: expose ReactServerPluginOptions #538

Merged
merged 3 commits into from
Jul 10, 2024
Merged

feat(next)!: expose ReactServerPluginOptions #538

merged 3 commits into from
Jul 10, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Jul 10, 2024 •
edited
Loading

Minor cleanup to properly structure ReactServerPluginOptions and ReactServerNextPluginOptions so that it allows routeDir: "src/app" for example.

Technically breaking since I need to manually add prerender: (_manifest, presets) => presets.generateStaticParams() in hi-ogawa/next-app-router-playground#1

@hi-ogawa Graphite App
Copy link
Owner Author

hi-ogawa commented Jul 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on Graphite Graphite

@hi-ogawa hi-ogawa changed the title feat(next): export ReactServerPluginOptions feat(next): exposeReactServerPluginOptions Jul 10, 2024
@hi-ogawa hi-ogawa changed the title feat(next): exposeReactServerPluginOptions feat(next)!: exposeReactServerPluginOptions Jul 10, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review July 10, 2024 08:21
@hi-ogawa hi-ogawa mentioned this pull request Jul 10, 2024
Merged
2 tasks
@hi-ogawa hi-ogawa changed the title feat(next)!: exposeReactServerPluginOptions feat(next)!: expose ReactServerPluginOptions Jul 10, 2024
@hi-ogawa hi-ogawa mentioned this pull request Jul 10, 2024
Closed
@hi-ogawa Graphite App
Copy link
Owner Author

hi-ogawa commented Jul 10, 2024 •
edited
Loading

Merge activity

  • Jul 10, 7:09 PM EDT: @hi-ogawa started a stack merge that includes this pull request via Graphite.
  • Jul 10, 7:09 PM EDT: @hi-ogawa merged this pull request with Graphite.

@hi-ogawa hi-ogawa merged commit 422b8b7 into main Jul 10, 2024
6 checks passed
@hi-ogawa hi-ogawa deleted the feat-next-export-plugin-options branch July 10, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hi-ogawa