Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): enable generateStaticParams #472

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Jul 1, 2024

For now, let's only enable generateStaticParams for the sake of demo hi-ogawa/next-app-router-playground#1.

Probably implementing Next's dynamic: "auto" heuristics would be too much.

It's also worth researching how other frameworks allow ssg configuration:

todo

  • test on app router demo
  • update cf adapters to exclude ssg paths

Copy link
Owner Author

hi-ogawa commented Jul 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on Graphite Graphite

@hi-ogawa hi-ogawa marked this pull request as ready for review July 1, 2024 07:55
Copy link
Owner Author

hi-ogawa commented Jul 1, 2024

Merge activity

  • Jul 1, 4:28 AM EDT: @hi-ogawa started a stack merge that includes this pull request via Graphite.
  • Jul 1, 4:32 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 1, 4:33 AM EDT: @hi-ogawa merged this pull request with Graphite.

@hi-ogawa hi-ogawa force-pushed the feat-next-compat-ssg branch from a5ec6a3 to d1aca63 Compare July 1, 2024 08:29
Base automatically changed from feat-next-compat-ssg to main July 1, 2024 08:31
@hi-ogawa hi-ogawa force-pushed the feat-next-compat-ssg-2 branch from 5f17afe to 093d384 Compare July 1, 2024 08:31
@hi-ogawa hi-ogawa merged commit b68d666 into main Jul 1, 2024
6 checks passed
@hi-ogawa hi-ogawa deleted the feat-next-compat-ssg-2 branch July 1, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant