fix(react-server): consistent history pathname encoding + support Link.activeProps
#276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavLink
matching react-server-demo-remix-tutorial#3location.pathname
is not encoded on client side navigation TanStack/router#1441I'm not sure whether the fix belongs to
@tanstack/history
itself. For now, we can just wraphistory.push/replace
to always keep encoded version as a history location.todo
activeProps
NavLink
's match logic also needs to be done against encoded version instead ofpropt.href
string directly.