Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-server): router transition state #224

Merged
merged 31 commits into from
Mar 25, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Mar 23, 2024

todo

  • expose isPending
    • separate ones for RSC and action?
    • action state is already managed by react https://react.dev/reference/react-dom/hooks/useFormStatus but this is available only locally, so we probably want something global one. test(react-server): test ReactDom.useFormStatus #225
    • back/forward navigation doesn't trigger transition?
      • for now, setTimeout to delay rsc transition after useRouter re-rendering?
      • can we implement "pending status" on user land without useTransition?
    • example global progress
      • animation works differently with StrictMode (head/body hoisting is working differently?)
        • well, it looks like it's fine now? I don't know what was happening anymore...
  • hooks for browser navigation state for client component (e.g. current url)
  • refactor context (later)
  • test
  • simplify browser root component (setRsc, updateRscByFetch, callServer, etc...?) still hacky but fine...
  • cloudflare workers crash?
    • handle undefined process.env.DEBUG

@hi-ogawa hi-ogawa mentioned this pull request Mar 24, 2024
69 tasks
@hi-ogawa hi-ogawa marked this pull request as ready for review March 24, 2024 10:20
@hi-ogawa hi-ogawa merged commit 4dadb80 into main Mar 25, 2024
4 checks passed
@hi-ogawa hi-ogawa deleted the feat-react-server-client-router branch March 25, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant