Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-server): render full html via RSC #203

Merged
merged 29 commits into from
Mar 18, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Mar 18, 2024

todo

  • dev: virtual:browser-bootstrap-module to wrap entry script with /@react-refresh and /@vite/client
  • build: use vite manifest to find /src/entry-client asset
  • css
    • expose dev/build css asset utility so that users can inject css manually in RSC layout?
    • automatically inject to ssr stream with virtual module?
  • demo, test
    • change meta on client side navigation
  • bootstrapModules
    • dev: ensure client entry runs after react/vite dev scripts
  • refactor
    • virtual:ssr-assets?
    • virtual module plugin wrapper

future

  • doubely rendered meta (e.g. <title> is rendered twice in layout and page) won't get automatically merged
  • make this mode as opt-in?
  • with this virtual:ssr-assets approach, we can uniformly handle css from RSC module graph too?
  • how does react do this? (hoistable elements)

@hi-ogawa hi-ogawa mentioned this pull request Mar 18, 2024
69 tasks
@hi-ogawa hi-ogawa marked this pull request as ready for review March 18, 2024 04:37
@hi-ogawa hi-ogawa merged commit 3f94ad8 into main Mar 18, 2024
4 checks passed
@hi-ogawa hi-ogawa deleted the feat-react-server-full-html branch March 18, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant