Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加企业微信群机器人通知(webhook) #810

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Conversation

kulokai
Copy link
Contributor

@kulokai kulokai commented Jul 14, 2020

企业微信群机器人文档 https://work.weixin.qq.com/help?person_id=1&doc_id=13376
企业微信应用通知文档 https://work.weixin.qq.com/api/doc/90000/90003/90487

企业微信通知是企业微信应用级别的通知,通过应用通知到具体的人;
新增的企业微信群机器人webhook,是将通知发送到群里,便于群里的人共同跟进。

@request-info
Copy link

request-info bot commented Jul 14, 2020

你好!感谢你反馈的问题/bug,但是你的描述好像是空的,我们需要你完整的信息,这样才能帮你解决问题 如果不知道怎么写,在新建issue的时候有若干个模板可供选择,祝好!

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #810 into master will decrease coverage by 0.04%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   78.45%   78.40%   -0.05%     
==========================================
  Files          80       80              
  Lines       11049    11064      +15     
==========================================
+ Hits         8668     8675       +7     
- Misses       2381     2389       +8     
Impacted Files Coverage Δ
common/utils/sendmsg.py 53.07% <12.50%> (-2.67%) ⬇️
sql/notify.py 88.88% <88.88%> (-0.23%) ⬇️
sql/admin.py 97.29% <100.00%> (ø)
sql/models.py 96.34% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39dc85...bd027b1. Read the comment docs.

@LeoQuote
Copy link
Collaborator

ho, 现在企业微信发消息这么简单了? sdk都不要了?

@LeoQuote LeoQuote added enhancement New feature or request and removed 请提供更多信息 labels Jul 14, 2020
@LeoQuote
Copy link
Collaborator

感谢提交, ci 过了应该问题不大, 我这里先通过了, 你在自己环境下测试过了吗? 有没有群机器人的文档? 后续如果出了问题方便排查一下

@LeoQuote LeoQuote self-requested a review July 14, 2020 09:03
LeoQuote
LeoQuote previously approved these changes Jul 14, 2020
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulokai
Copy link
Contributor Author

kulokai commented Jul 14, 2020

企业微信群机器人文档 https://work.weixin.qq.com/help?person_id=1&doc_id=13376
在自己的环境测试通过了
image

@LeoQuote

@LeoQuote
Copy link
Collaborator

能不能加个额外的说明, 讲明已有的企业微信和现在的企业微信webhook 的差别. 怕用的人看到两个企业微信比较困惑.

@kulokai
Copy link
Contributor Author

kulokai commented Jul 14, 2020

能不能加个额外的说明, 讲明已有的企业微信和现在的企业微信webhook 的差别. 怕用的人看到两个企业微信比较困惑.

原企业微信是企业微信应用级别的通知,通过应用通知到具体的人;
新增的企业微信群机器人webhook,是将通知发送到群里,便于群里的人共同跟进。

原企业微信的通知 同飞书应用
新增的企业微信webhook 同飞书webhook

@LeoQuote
Copy link
Collaborator

好的, 可以麻烦写到网页上吗?

Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

赞, CI 过了就能合了

@kulokai
Copy link
Contributor Author

kulokai commented Jul 14, 2020

image
追加了网页上的友好提示 @LeoQuote

@LeoQuote LeoQuote merged commit c63393c into hhyo:master Jul 14, 2020
@LeoQuote
Copy link
Collaborator

感谢提交, 应该近期会发布.

@hhyo
Copy link
Owner

hhyo commented Jul 14, 2020

感谢贡献

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants