insert all语法支持 #740
Merged
insert all语法支持 #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insert all语法支持
LeoQuote
reviewed
May 15, 2020
sql/engines/oracle.py
Outdated
| @@ -232,14 +232,22 @@ def get_dml_table(sql='', object_name_list=None, db_name=''): | |||
| return True | |||
| else: | |||
| return False | |||
| elif re.match(r"^insert", sql): | |||
| elif re.match(r"^insert\s+into\s", sql): | |||
There was a problem hiding this comment.
我理解是不是这里直接改一下正则就行, 不用这样又匹配一次吧? 里面要做的事情完全一样的
There was a problem hiding this comment.
好的，最近有空调整测试验证一下这边，顺便把备份未判断工单是否需要备份的bug修复一下
hhyo
requested changes
May 16, 2020
sql/engines/oracle.py
Outdated
| @@ -232,14 +232,22 @@ def get_dml_table(sql='', object_name_list=None, db_name=''): | |||
| return True | |||
| else: | |||
| return False | |||
| elif re.match(r"^insert", sql): | |||
| elif re.match(r"^insert\s+into\s", sql): | |||
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
=======================================
Coverage 79.24% 79.24%
=======================================
Files 78 78
Lines 10850 10851 +1
=======================================
+ Hits 8598 8599 +1
Misses 2252 2252
Continue to review full report at Codecov.
|
hhyo
requested changes
May 22, 2020
| end_time = rows[0] | ||
| self.backup(workflow, cursor=cursor, begin_time=begin_time, end_time=end_time) | ||
| except Exception as e: | ||
| logger.error(f"Oracle工单备份异常，工单id：{workflow.id}， 错误信息：{traceback.format_exc()}") |
hhyo
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insert all语法支持