fix the template of inception and goinception #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 78 78
Lines 10532 10532
=======================================
Hits 8546 8546
Misses 1986 1986 Continue to review full report at Codecov.
|
|
唉，我好像审之前关于chart的pr的时候没仔细审，这个volume和volumemount麻烦都挪到templates里面吧，放在values里面给用户定义完全没意义。 |
|
都放到 templates 也可以 |
|
你测试没问题吧, 我直接合了 |
|
没问题的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
values里没有定义volumeMounts会导致生成的 deployment 里其实没有把 configMap 挂载到 pod, 这样 configMap 就没法使用了