Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix black #2493

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix black #2493

merged 1 commit into from
Jan 29, 2024

Conversation

LeoQuote
Copy link
Collaborator

black 更新之后多了些规则, 批量优化一下

@@ -699,7 +705,9 @@
conn.commit()
cursor.close()
except Exception as e:
logger.warning(f"MySQL语句执行报错,语句:{sql},错误信息{traceback.format_exc()}")
logger.warning(
f"MySQL语句执行报错,语句:{sql},错误信息{traceback.format_exc()}"

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (password)
as clear text.
@@ -171,7 +175,9 @@
if r_json["errcode"] == 0:
logger.debug(f"钉钉推送成功\n通知对象:{userid_list}\n消息内容:{content}")
else:
logger.error(f"钉钉推送失败\n请求连接:{send_url}\n请求参数:{data}\n请求响应:{r_json}")
logger.error(
f"钉钉推送失败\n请求连接:{send_url}\n请求参数:{data}\n请求响应:{r_json}"

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (secret)
as clear text.
This expression logs
sensitive data (secret)
as clear text.
@@ -191,7 +197,9 @@
if r_json["errcode"] == 0:
logger.debug(f"企业微信推送成功\n通知对象:{to_user}")
else:
logger.error(f"企业微信推送失败\n请求连接:{send_url}\n请求参数:{data}\n请求响应:{r_json}")
logger.error(
f"企业微信推送失败\n请求连接:{send_url}\n请求参数:{data}\n请求响应:{r_json}"

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (secret)
as clear text.
This expression logs
sensitive data (secret)
as clear text.
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (7e2d5e7) 76.97% compared to head (2667b75) 76.97%.

Files Patch % Lines
sql/instance_account.py 0.00% 9 Missing ⚠️
common/utils/sendmsg.py 28.57% 5 Missing ⚠️
sql/engines/oracle.py 0.00% 4 Missing ⚠️
sql/query_privileges.py 33.33% 4 Missing ⚠️
sql/archiver.py 50.00% 2 Missing ⚠️
sql/engines/mongo.py 0.00% 2 Missing ⚠️
sql/engines/mysql.py 50.00% 2 Missing ⚠️
sql/engines/phoenix.py 0.00% 2 Missing ⚠️
sql/instance_database.py 0.00% 2 Missing ⚠️
sql/query.py 0.00% 2 Missing ⚠️
... and 13 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2493   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files         115      115           
  Lines       15945    15945           
=======================================
  Hits        12274    12274           
  Misses       3671     3671           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoQuote
Copy link
Collaborator Author

@hhyo 有空帮忙 merge 下, 都只是样式修改, 和逻辑不相关

@hhyo hhyo merged commit 8bec5f4 into hhyo:master Jan 29, 2024
8 of 10 checks passed
@LeoQuote LeoQuote deleted the fix-black branch April 16, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants