-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
数据库查询字段不区分大小写,脱敏失败问题 #2332
数据库查询字段不区分大小写,脱敏失败问题 #2332
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2332 +/- ##
=======================================
Coverage 75.75% 75.75%
=======================================
Files 108 108
Lines 15681 15687 +6
=======================================
+ Hits 11879 11884 +5
- Misses 3802 3803 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果是数据库的特性的话, 在 engine 部分实现比较好
|
This comment was marked as off-topic.
This comment was marked as off-topic.
看一下 CI, 必须要过才能合并, 可以先 rebase 下 master 谢谢 |
脱敏这个功能不是很通用,有的时候不会去配置脱敏规则,如果在需要配置脱敏规则的时候,标注下当前规则是否区分大小写,更方便一些感觉。 |
这块是不是匹配时直接不区分大小写就可以了 没有太大的必要单独配置 |
直接不区分大小写的话其实大部分时候是可以的,就是对于配置规则的人来说,如果他有个字段他真的是大写或者大小写混合,最后也会被脱敏掉,可能稍微有一点点奇怪, 对于区分大小写的pg数据库,如果大写的字段被小写的规则命中脱敏掉,好像不是很合理。 |
既然除了大小写都一样,理论上存储内容也不应该有太大差别,先做最小化调整在匹配时忽略大小写吧 |
重新修改代码! |
fix #2328
解决数据库脱敏失败问题,mysql,sqlserver,oracle 列名不区分大小写,pg区分,所以考虑在脱敏表中新添加一个字段标记是否区分大小写。