Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config for ban_self_audit #2040

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

delphid
Copy link
Contributor

@delphid delphid commented Jan 29, 2023

#2039

Prevent the situation of workflow auditor being the same as workflow creator:

  • superuser will not be limited
  • introduced as a config option, default disabled

@delphid delphid force-pushed the feature/ban_self_audit branch 2 times, most recently from a4a721d to ce2da2f Compare January 30, 2023 06:48
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 75.00% // Head: 75.03% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (241240d) compared to base (fefb8fc).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2040      +/-   ##
==========================================
+ Coverage   75.00%   75.03%   +0.03%     
==========================================
  Files         102      102              
  Lines       14779    14809      +30     
==========================================
+ Hits        11085    11112      +27     
- Misses       3694     3697       +3     
Impacted Files Coverage Δ
sql/utils/workflow_audit.py 96.99% <80.00%> (-1.02%) ⬇️
sql/utils/tests.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@delphid delphid force-pushed the feature/ban_self_audit branch from ce2da2f to 230a96c Compare January 30, 2023 07:36
@delphid
Copy link
Contributor Author

delphid commented Jan 30, 2023

Publish Docker image check error

depend on #2041

@delphid delphid force-pushed the feature/ban_self_audit branch 2 times, most recently from e1f7d45 to 4646c85 Compare January 30, 2023 14:44
@delphid delphid force-pushed the feature/ban_self_audit branch from 4646c85 to af02796 Compare January 31, 2023 05:42
@delphid delphid force-pushed the feature/ban_self_audit branch from af02796 to 61eded7 Compare January 31, 2023 06:42
@delphid delphid force-pushed the feature/ban_self_audit branch from 61eded7 to 241240d Compare January 31, 2023 06:44
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeoQuote LeoQuote merged commit cef6e68 into hhyo:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants