Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

变更dockerfile-base #2021

Merged
merged 1 commit into from
Jan 17, 2023
Merged

变更dockerfile-base #2021

merged 1 commit into from
Jan 17, 2023

Conversation

peng19832
Copy link
Contributor

使用多段构建,精简base镜像体积

@LeoQuote
Copy link
Collaborator

LeoQuote commented Jan 6, 2023

这次的好像过了,不要关pr ,等一下我们审核。

@peng19832
Copy link
Contributor Author

peng19832 commented Jan 6, 2023

这次的好像过了,不要关pr ,等一下我们审核。

刚才发现,有一行没有行末连接符,commit也有点多,看起挺麻烦,就关了,重新搞了下。
等你们审核完,我再提应用的
我这docker hub页面也打不开,到时估计也看不到新base镜像的tag号

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 75.00% // Head: 75.00% // No change to project coverage 👍

Coverage data is based on head (8aab2e4) compared to base (4fdf73c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2021   +/-   ##
=======================================
  Coverage   75.00%   75.00%           
=======================================
  Files         102      102           
  Lines       14779    14779           
=======================================
  Hits        11085    11085           
  Misses       3694     3694           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hhyo hhyo requested a review from LeoQuote January 13, 2023 01:01
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhyo hhyo merged commit b3a08ef into hhyo:master Jan 17, 2023
@hhyo
Copy link
Owner

hhyo commented Jan 17, 2023

基于这个base hhyo/archery-base:sha-b3a08ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants