Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

支持Oracle会话管理 #1954

Merged
merged 2 commits into from
Nov 6, 2022
Merged

支持Oracle会话管理 #1954

merged 2 commits into from
Nov 6, 2022

Conversation

nick2wang
Copy link
Collaborator

支持Oracle会话管理:

  1. 会话状态查看管理
  2. Top表空间查看
  3. 锁信息查看

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 75.90% // Head: 75.94% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (ffe1e90) compared to base (027904f).
Patch coverage: 80.86% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1954      +/-   ##
==========================================
+ Coverage   75.90%   75.94%   +0.03%     
==========================================
  Files          91       91              
  Lines       14204    14319     +115     
==========================================
+ Hits        10782    10875      +93     
- Misses       3422     3444      +22     
Impacted Files Coverage Δ
sql/db_diagnostic.py 15.58% <0.00%> (-1.32%) ⬇️
sql/engines/oracle.py 48.57% <81.48%> (+2.88%) ⬆️
sql/engines/tests.py 99.78% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@hhyo hhyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

语句拼接会有注入风险么

@nick2wang
Copy link
Collaborator Author

语句拼接会有注入风险么

拼接kill语句有做校验,session list有个不必要的直接传参拼接可以去掉

@hhyo hhyo merged commit 287e74a into hhyo:master Nov 6, 2022
@nick2wang nick2wang deleted the oracle-diagnostic branch November 7, 2022 01:18
@nick2wang nick2wang restored the oracle-diagnostic branch November 7, 2022 01:20
nick2wang added a commit to nick2wang/Archery that referenced this pull request Nov 7, 2022
* 支持Oracle会话管理

* 删除非必要sql拼接

(cherry picked from commit 287e74a)
@nick2wang nick2wang deleted the oracle-diagnostic branch November 7, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants