Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

工单通知分阶段控制 #1406

Merged
merged 5 commits into from
Mar 6, 2022
Merged

工单通知分阶段控制 #1406

merged 5 commits into from
Mar 6, 2022
+72 −15

Conversation

nick2wang
Copy link
Collaborator

相关issue：#1340

新增参数notify_phase_control，对工单4个阶段的通知做独立控制，默认全部开启：
Apply：工单申请
Pass：审核通过
Execute：执行结束
Cancel：取消驳回
image

@nick2wang
工单通知分阶段控制

Verified

This commit was signed with the committer’s verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5
Verified
Learn about vigilant mode
6ec2537 
工单通知分阶段控制
@codecov
Copy link

codecov bot commented Mar 4, 2022 •
edited
Loading

Codecov Report

Merging #1406 (1bdc9f1) into master (a7cde53) will increase coverage by 0.02%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
+ Coverage   74.91%   74.94%   +0.02%     
==========================================
  Files          82       82              
  Lines       13191    13205      +14     
==========================================
+ Hits         9882     9896      +14     
  Misses       3309     3309
Impacted Files Coverage Δ
sql/sql_workflow.py 68.27% <93.75%> (+0.92%) ⬆️
sql/utils/execute_sql.py 88.00% <100.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7cde53...1bdc9f1. Read the comment docs.

@nick2wang nick2wang linked an issue Mar 4, 2022 that may be closed by this pull request
资源组中的实例如何针对工单的某一个阶段推送消息到webhook #1340
Closed
hhyo
hhyo reviewed Mar 5, 2022
View reviewed changes
nick2wang added 4 commits March 5, 2022 12:49
@nick2wang
Revert "移除配置信息的缓存依赖"

Verified

This commit was signed with the committer’s verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5
Verified
Learn about vigilant mode
bb4d1f3 
This reverts commit 7fd62b2.

# Conflicts:
#	common/config.py
#	common/templates/config.html
@nick2wang
Merge remote-tracking branch 'upstream/master' into nick-notification

Verified

This commit was signed with the committer’s verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5
Verified
Learn about vigilant mode
f15580e
@nick2wang
Revert "Revert "移除配置信息的缓存依赖""

Verified

This commit was signed with the committer’s verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5
Verified
Learn about vigilant mode
abbf5df 
This reverts commit bb4d1f3.
@nick2wang
参数改为在前台处理

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 933B01F40B5CA946
Expired
Learn about vigilant mode
1bdc9f1 
参数改为在前台处理
@hhyo hhyo merged commit bbcf17a into hhyo:master Mar 6, 2022
@nick2wang nick2wang deleted the nick-notification branch March 7, 2022 09:30
xxlaila pushed a commit to xxlaila/Archery that referenced this pull request Feb 15, 2025
@nick2wang
工单通知分阶段控制 (hhyo#1406)

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 933B01F40B5CA946
Expired
Learn about vigilant mode
b56a8df 
* 工单通知分阶段控制

工单通知分阶段控制

* Revert "移除配置信息的缓存依赖"

This reverts commit 7fd62b2.

# Conflicts:
#	common/config.py
#	common/templates/config.html

* Revert "Revert "移除配置信息的缓存依赖""

This reverts commit bb4d1f3.

* 参数改为在前台处理

参数改为在前台处理
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhyo hhyo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

资源组中的实例如何针对工单的某一个阶段推送消息到webhook
2 participants
@nick2wang @hhyo