Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed display of hour plus long tracks #153

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thehalvo
Copy link

Description

If a meditation track was greater than 59:59 it would not display the hours. It would just leave them out.

Ticket Link

N/A

How has this been tested?

Tested the play screen using these devices:

iPhone 13 - Simulator

Screenshots

Screen Shot 2022-06-24 at 12 12 59 AM

Checklist

  • Added a "Closes [issue number]" in the ticket link section
  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens

@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for webheylinda ready!

Name Link
🔨 Latest commit 2bce04a
🔍 Latest deploy log https://app.netlify.com/sites/webheylinda/deploys/64a304931b46c200089aa2f1
😎 Deploy Preview https://deploy-preview-153--webheylinda.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@watadarkstar
Copy link
Collaborator

Awesome @thehalvo!

Thanks for fixing this issue. Can you add some additional tests for this case here so we don't ever regress:
https://github.com/heylinda/heylinda-app/blob/main/hooks/__tests__/useMsToTime.tests.ts

@thehalvo
Copy link
Author

@watadarkstar sure done.

hooks/useMsToTime.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants