Adding --offline option to hex.docs open #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hex.docs open will go online to hexdocs.pm unless --offline option is specified.
ericmj
requested changes
Sep 23, 2016
| Mix.raise "Documentation file not found: #{path}" | ||
| end | ||
|
|
||
| path |> browser_open |
There was a problem hiding this comment.
We usually avoid pipelines if it's just a single pipe like this. browser_open(path) is clearer.
There was a problem hiding this comment.
Sure. I'll update it and also add --offline to the unit tests also.
lexmag
suggested changes
Sep 23, 2016
| defp open_docs([name], opts) do | ||
| defp open_docs(package, opts) do | ||
| if opts[:offline] do | ||
| package |> open_docs_offline(opts) |
ottolin
force-pushed
the
hex.docs_open_offline
branch
from
9d4b5fe to
b73ccdc
Compare
lexmag
reviewed
Sep 23, 2016
| @@ -96,22 +96,36 @@ defmodule Mix.Tasks.Hex.Docs do | |||
| Mix.raise "You must specify at least the name of a package" | |||
| end | |||
|
|
|||
| defp open_docs([name], opts) do | |||
| defp open_docs(package, opts) do | |||
| if opts[:offline] do | |||
There was a problem hiding this comment.
I think we should add offline: boolean switch to OptionParser.parse/2 call.
|
Great job @ottolin! 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hex.docs open will go online to hexdocs.pm
unless --offline option is specified.
fix #291