Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hex.key to hex.user keys #305

Closed
josevalim opened this issue Oct 29, 2016 · 2 comments
Closed

Move hex.key to hex.user keys #305

josevalim opened this issue Oct 29, 2016 · 2 comments

Comments

@josevalim
Copy link
Member

Given those commands require user authentication and are associated to the logged in user, it seems clearer to move them there. It would also reduce the amount of tasks. remove could become remove --remove NAME and --remove all could become --remove-all.
milmazz added a commit to milmazz/hex that referenced this issue Dec 26, 2016
@milmazz
Move hex.key tasks to hex.user
b62ed34 
Fixes: hexpm#305
@milmazz milmazz mentioned this issue Dec 26, 2016
Merged
milmazz added a commit to milmazz/hex that referenced this issue Dec 26, 2016
@milmazz
Move hex.key tasks to hex.user
836c060 
Fixes: hexpm#305
milmazz added a commit to milmazz/hex that referenced this issue Dec 26, 2016
@milmazz
Move hex.key tasks to hex.user
727026f 
Fixes: hexpm#305
milmazz added a commit to milmazz/hex that referenced this issue Dec 26, 2016
@milmazz
Move hex.key tasks to hex.user
7e18935 
Fixes: hexpm#305
@milmazz
Copy link
Contributor

milmazz commented Dec 27, 2016

I think this issue is already fixed

@ericmj
Copy link
Member

ericmj commented Dec 27, 2016

Closing in favor of PR #334.

@ericmj ericmj closed this as completed Dec 27, 2016
ericmj pushed a commit that referenced this issue Dec 28, 2016
@milmazz @ericmj
Move hex.key tasks to hex.user (#334)
608d2b1 
Fixes: #305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josevalim @milmazz @ericmj